Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-194 ECS - Support central ordering in the acq modules #784

Merged
merged 21 commits into from
Jul 2, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Jun 17, 2024

Purpose

https://folio-org.atlassian.net/browse/UISACQCOMP-194

Central ordering in the receiving application implies the possibility of action within two tenants (central and active - system) without switching the active affiliation. To implement this feature, many components must be updated to support sending requests to the specified tenant.

Approach

Most components that load data over the network use the system tenant ID (from the stripes object), so data is always loaded from the active affiliation. It is necessary to update components, hooks, and utilities used in applications where central ordering is required to allow explicit specification of the tenant (tenantId) to which requests should be directed.

Also, to create conditions for reusing hooks and unifying the approach to data loading, components using mutators and stripesConnect are refactored to use react-query hooks.

Screenshot

chrome_twouMDsfGm.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

Jest Unit Test Statistics

    1 files  ±0  204 suites  +8   3m 52s ⏱️ +19s
520 tests +8  518 ✔️ +7  2 💤 +1  0 ±0 
523 runs  +8  521 ✔️ +7  2 💤 +1  0 ±0 

Results for commit b20f061. ± Comparison against base commit e6ed48a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 17, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b20f061. ± Comparison against base commit e6ed48a.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam marked this pull request as ready for review June 25, 2024 08:30
@usavkov-epam usavkov-epam requested review from a team June 25, 2024 13:59
@BogdanDenis BogdanDenis requested a review from a team June 26, 2024 12:43
Copy link
Contributor

@alisher-epam alisher-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jul 1, 2024

@usavkov-epam usavkov-epam merged commit 05f04cf into master Jul 2, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UISACQCOMP-194 branch July 2, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants